SearchKit - Allow subsearch of different types - #34853

@colemanw could we remove type and settings here and fetch them in the component based on search and display?

Ah, yea they're probably usually contained within those arrays.

@ufundo actually no, they're not. search and display are strings not arrays. The only array passed in is the settings. So all this stuff needs to be passed thru.

So my thinking is they are logically dependent, rather than literally one includes the other.

My first though was something like:

this.$onInit = () => {
   this.display = crmApi4('SearchDisplay', 'get', {
     select: ['type', 'settings'],
     where: [['name', '=', this.display], ['saved_search_id.name', '=', this.search]]
   })[0];
   ...

It's an extra api request, and it wont work well in the editor, but it is much more convenient if you are writing html/smarty templates to not have to fetch those things in advance.

Maybe it could be a fallback/lazy option:

this.$onInit = () => {
   if (!this.type || !this.settings) {
     const savedDisplay = crmApi4('SearchDisplay', 'get', {
       select: ['type', 'settings'],
       where: [['name', '=', this.display], ['saved_search_id.name', '=', this.search]]
     })[0];
     this.type = this.type ? this.type : savedDisplay['type'];
     this.settings = this.settings ? this.settings : savedDisplay['type'];
     ...

That would be more of a follow-up than a blocker.

@ufundo it sounds like a good idea, but I think there's 2 potential problems:

1. In a Subsearch scenario, with 50 rows per page (default) that's 50 extra ajax requests per subsearch!
2. Users might not be allowed to call the 'SearchDisplay', 'get' ajax api depending on their permission levels.

If we really wanted to solve both problems, the metadata about the search display could be returned as part of the first searchDisplay.run request as an extra SearchDisplayRunResult property... In theory, I haven't tried it, you could fetch metadata about the search AND run the search in the same ajax request.
But that's a potentially YAGNI project and we've got bigger priorities IMO.

The real downside to this PR is that it loads ALL searchDisplay code ALL the time (e.g. all of ChartKit, etc). But js is browser-cacheable so probably not worth wringing our hands about.